Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for rerunning tool with workflow resume that is part of a collection. #3019

Merged
merged 1 commit into from
Oct 14, 2016

Conversation

blankenberg
Copy link
Member

@blankenberg blankenberg commented Oct 7, 2016

The special casing of |__identifier__ that occurs here and elsewhere in the code is less than ideal.

The special casing of "__identifier__" that occurs here and elsewhere in the code is less than ideal.
@blankenberg blankenberg added this to the 16.10 milestone Oct 7, 2016
@nsoranzo nsoranzo changed the title Fix for reruning tool with workflow resume that is part of a collection. Fix for rerunning tool with workflow resume that is part of a collection. Oct 7, 2016
@nsoranzo
Copy link
Member

nsoranzo commented Oct 7, 2016

This should be a partial fix for #2235, according to @blankenberg's comments from IRC:

yes, this should fix the things inside the collection and downstream
hmm, actually, looks like it doesn't fix it in the original collection, but the downstream collections update
so if the one failure occurs a tool or more upstream, the final collections will be ok
if the failure occurs on the final collection, #3019 doesn't help

@blankenberg
Copy link
Member Author

Any other comments on this PR?

@martenson martenson merged commit a895c82 into galaxyproject:dev Oct 14, 2016
@martenson
Copy link
Member

afaik This should allow resuming a workflow that has been waiting on a failed dataset in a collection. It will rerun the failed dataset (but not update it in the collection) and allow the downstream tools to be run/unpaused.
Thank you @blankenberg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants