Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has_size option #8852

Merged
merged 23 commits into from
Oct 23, 2019
Merged

Add has_size option #8852

merged 23 commits into from
Oct 23, 2019

Conversation

simonbray
Copy link
Member

Allows checking file size in tests directly without having to use sim_size and a test file. See #8838

@simonbray
Copy link
Member Author

simonbray commented Oct 23, 2019

Some questions:

@galaxybot galaxybot added this to the 20.01 milestone Oct 23, 2019
@mvdbeek
Copy link
Member

mvdbeek commented Oct 23, 2019

  • I guess I should write a test, where should this go?

As far as I can tell there are no unit tests for test assertions. If you want to write these that would be awesome, it should be relatively straightforward. I think it's also OK if you just add the assertion to one of the test tools in test/functional/tools.

  • galaxy.xsd would also have to be updated in the planemo repo, should I also submit a PR for that?

We're going (or maybe we already did?) to refactor planemo to get this file from the tool_util package, so no.

It'll be generated from the schema

@nsoranzo
Copy link
Member

We're going (or maybe we already did?) to refactor planemo to get this file from the tool_util package, so no.

I've got a WIP patch locally, but first we need to address common-workflow-language/cwltool#1155

@martenson martenson merged commit 472f69f into galaxyproject:dev Oct 23, 2019
@martenson
Copy link
Member

thanks @simonbray !

@simonbray simonbray deleted the check-size branch October 24, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants