[19.05] Fix input parameter comparisons #9047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes galaxyproject/tools-iuc#2702 (comment) Broken in galaxyproject#7826 Also compares via `float` instead of `int` when other is int, since that is more reasonable. Otherwise 5.1 > 5 is False.
5 tasks
nsoranzo
reviewed
Nov 29, 2019
nsoranzo
reviewed
Nov 29, 2019
nsoranzo
reviewed
Nov 29, 2019
Cast self instead of other. This fails 5 == '5', which is less magic (galaxyproject#9047 (comment))
nsoranzo
reviewed
Nov 29, 2019
Co-Authored-By: Nicola Soranzo <nicola.soranzo@gmail.com>
Yep, thanks for the help and discussions. |
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Nov 29, 2019
Cast self instead of other. This fails 5 == '5', which is less magic (galaxyproject#9047 (comment))
nsoranzo
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes galaxyproject/tools-iuc#2702 (comment)
Broken in #7826
The implementation of
__gt__and__eq__is simpler now. One possible breaking change is that a TextToolParameter with value "5" is not equal to a literal 5 anymore. I doubt anyone relied on this behavior.