-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload results to results branch #152
Upload results to results branch #152
Conversation
name: checkout results | ||
- run: | | ||
git checkout results -- results | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: checkout results | |
- run: | | |
git checkout results -- results | |
- name: Checkout results | |
uses: actions/checkout@v4 | |
with: | |
path: results | |
ref: results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that, but the output would be that the results folder is a subfolder of results
as path
specifies a Relative path under $GITHUB_WORKSPACE to place the repository
. This below works, but is not so elegant I feel. But according to actions/checkout#1430 that seems to be the way atm.
steps:
- name: Checkout main
uses: actions/checkout@v4
- name: Checkout results
uses: actions/checkout@v4
with:
ref: results
sparse-checkout: results
path: .tmp
- name: Move results to root #https://github.com/actions/checkout/issues/1430
run: |
mv tmp/results results &&
rm .tmp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you want to use a sparse checkout in the first place?
I thought the result files would all be on the results
branch. If you put the result files on that branch directly, and not under some sub-directory, then the result files should be checked out as /results
, I'd expect. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope I was missing something, I was assuming a subfolder, but it is indeed as you describe, so that should work, will adapt the code for it
I think this could work, but we need to:
|
I did set up the branch structure as planned in my fork: The test CI worked for the tools (tutorials fails due to plausible API key). |
I think you should set up the results branch as an orphan, so that it won't be cluttered with files from main branch (https://github.com/paulzierep/galaxy_tool_extractor/tree/results/.github/workflows and others) or previous commits. |
Ah nice, thanks for pointing that out ! |
I added some additional fixes such as:
I am currently running the fetch tool and fetch tutorials CI on my fork and will make a PR once that succeeds. |
Ping @bebatut (https://github.com/paulzierep/galaxy_tool_extractor/actions/runs/9991639886/job/27614847200) maybe we also need a wait here ? |
Interesting, it always takes the test repo: https://github.com/paulzierep/galaxy_tool_extractor/actions/runs/9992041760/job/27616120191 |
Fixed with: 3d47a94 |
With the fixes its working on my fork: |
Added the up-to-date results here. I think we can merge. |
This is the initial CI set up to upload the results to a dedicated results branch, instead of the main branch.
We need:
A good name for that branch ->
results
OK ?All data generated by the CI must go into the results folder.
@nsoranzo for the filter and merge steps we need the functions from the main branch but also the content from results branch, do you have good idea to set that up in the CI ? Checkout main, then checkout only results folder?