Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support systemd as a process manager #77

Merged
merged 27 commits into from
Oct 20, 2022

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Oct 12, 2022

Also, prefer "passing through" galaxyctl exec so that the service units (or supervisor configs, when using supervisor) don't have to be rewritten every time there is a change. Regardless of what PM you use, you can run galaxyctl exec <service_name> to just run one of the services in the foreground, and this is now the command written to the process manager configs. If you don't want Gravity to write your systemd/supervisor configs, you can just write your own that call galaxyctl exec ... as necessary. This makes us behave more like a "normal" project that just deals with execution, not deployment, in a command line tool.

This change also pretty much removes the need for configstate. We should be able to remove it in the default case of a single config/instance of galaxy, e.g. if you set $GALAXY_CONFIG_FILE or a (new, not yet created) global -c/--galaxy-config option then we can just skip the configstate entirely.

I have to remember how to update the docs, and create a corresponding PR in Galaxy to update the docs and document how to set start_timeout and stop_timeout on handler defs.

@natefoo natefoo merged commit 1c3c21b into galaxyproject:release_1.x Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant