Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors reported by flake8 3.6.0 #2160

Merged
merged 6 commits into from
Oct 30, 2018

Conversation

nsoranzo
Copy link
Member

Ignore W503 and W504.

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

FOR REVIEWER:

  • .shed.yml file ok
    • Toolshed user iuc has access to associated toolshed repo(s)
  • Indentation is correct (4 spaces)
  • Tool version/build ok
  • <command/>
    • Text parameters, input and output files 'single quoted'
    • Use of <![CDATA[ ... ]]> tags
    • Parameters of type text or having optional="true" attribute are checked with if str($param) before being used
  • Data parameters have a format attribute containing datatypes recognised by Galaxy
  • Tests
    • Parameters are reasonably covered
    • Test files are appropriate
  • Help
    • Valid restructuredText and uses <![CDATA[ ... ]]> tags
  • Complies with other best practice in Best Practices Doc

@nsoranzo
Copy link
Member Author

nsoranzo commented Oct 30, 2018

Tests for qiime_core tools fail because when biom-format package (a dependency of qiime) was moved from bioconda to conda-forge, the pyqi dependency was omitted. To fix that, we need conda-forge/biom-format-feedstock#4 .

Update: I've added pyqi to conda-forge in conda-forge/staged-recipes#6940

@nsoranzo nsoranzo mentioned this pull request Oct 30, 2018
20 tasks
@nsoranzo
Copy link
Member Author

Now all qiime_core tests pass for me locally, but time out on Travis.

@mvdbeek mvdbeek merged commit a4b0969 into galaxyproject:master Oct 30, 2018
@nsoranzo nsoranzo deleted the flake8_3.6.0 branch October 31, 2018 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants