Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raxml: add python requirement #2707

Merged

Conversation

bernt-matthias
Copy link
Contributor

and fix test data

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@bernt-matthias
Copy link
Contributor Author

bump?

@bgruening
Copy link
Member

Yes, please.

OM: CLI options DEBUG START:
<Values at 0x7f8e104919e0: {'bootseed': None, 'groupingfile': None, 'posterior_bootstopping_analysis': None, 'print_branch_lengths': None, 'starting_tree': None, 'model_opt_precision': None, 'weightfile': None, 'use_median_approximation': None, 'majority_rule_consensus': None, 'excludefile': None, 'save_memory_gappy_alignments': None, 'binary': 'raxmlHPC', 'numofcats': None, 'multistate_sub_model': None, 'multiple_model': None, 'search_complete_random_tree': None, 'source': '/tmp/tmpS1corm/files/000/dataset_7.dat', 'outgroup_name': None, 'estimate_individual_branch_lengths': None, 'ml_search_convergence': None, 'file_multiple_trees': None, 'rapid_bootstrap_random_seed': None, 'random_seed': 1234567890, 'disable_undetermined_seq_check': None, 'save_memory_cat_model': None, 'enable_evol_heuristics': None, 'aa_empirical_freq': None, 'threads': 1, 'external_protein_model': None, 'search_algorithm': 'd', 'constraint_file': None, 'secondary_structure_model': None, 'number_of_runs': 5, 'name': None, 'initial_rearrangement_setting': None, 'secondary_structure_file': None, 'model_type': 'nucleotide', 'aa_search_matrix': None, 'disable_rate_heterogeneity': None, 'base_model': 'GTRCAT', 'parsimony_starting_tree_only': None, 'number_of_runs_bootstop': None, 'sliding_window_size': None, 'bin_model_parameter_file': None}>
OM: CLI options DEBUG END
RAxML_parsimonyTree.galaxy.RUN.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected that the test data output changed so much ? Could these changes be due to galaxyproject/galaxy#9052 as well ?

Copy link
Contributor Author

@bernt-matthias bernt-matthias Dec 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this output is a (extended) newick format. It seems that originally the content of the log file was used for this output.

I just added the ftype="nhx" attribute to the test outputs .. but I guess this won't help anyway since nhx has no sniffer (yet).

Also in my opinion the output is wrong since the names between the trees are not allowed. Question is is downstream tools silently accept this or if we should change it (it comes from the Galaxy tool specific py script)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be in favor of adhering to the correct format. 5f148a7 does this, correct ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the best of my knowledge, yes.

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this!

@mvdbeek mvdbeek merged commit 9f9e37b into galaxyproject:master Dec 2, 2019
@bernt-matthias bernt-matthias deleted the topic/raxml-container-fixes branch March 8, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants