hmmer3: update and nhmmer test fixes #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexylena
approved these changes
Dec 2, 2019
|
I think the tests fail because now 3.2.1 is used instead of 3.2.
|
bernt-matthias
force-pushed
the
topic/hmmer3-container-fixes
branch
from
39e7ce1 to
52b9672
Compare
|
Also upgraded to 3.3. .. according to the changelog there seem to be no changes in the CLI. aliscore output in nhmmer scan creates segfault (reported here EddyRivasLab/hmmer#190). So I enabled it for testing in nhmmer search... still keeping the test file for scan for when it works again. Needed to update quite a bit of the test data since numeric values changed. |
bernt-matthias
changed the title
|
Also added some |
|
Still failing ... :( |
- better code reuse for the output flag macro - unified token for generation of the output arguments - added macros for the outputs - output labels changed now TOOL on onstring (so I keep the capitalisation but do not use the dataset names anymore) - added content asserions for outputs of all tools
bernt-matthias
force-pushed
the
topic/hmmer3-container-fixes
branch
from
865fb47 to
a38fc75
Compare
mvdbeek
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remaining problems seem due to the fact that nowadays v3.2.1 is used instead of 3.2. Could we fix this? Or better update test data?
since so far only tests changed I did not bump the tool version .. just kidding (I forgot it) ..
FOR CONTRIBUTOR: