-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update orthofinder and pick up new orthogroup output #5705
Update orthofinder and pick up new orthogroup output #5705
Conversation
<requirements> | ||
<requirement type="package" version="@TOOL_VERSION@">orthofinder</requirement> | ||
<requirement type="package" version="2.36">util-linux</requirement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests should show if we can really remove this. Has been added here to allow for containerized tests: #2757
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. That was a mistake. But it passed the tests using this singularity container (and no other dependencies): bioconda/bioconda-recipes#45149 (comment)
Thanks for spotting that, I will test it again once the new container is on quay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bernt-matthias this passes tests with the new biocontainer, run in Apptainer, without the util-linux
requirement.
Do you think I should leave util-linux
out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomHarrop is this still Draft?
Yes. According to the manual the main output been deprecated and I have to pick up the new output in the wrapper. |
Thanks @bgruening, all done now |
Pick up new "Hierarchical Orthogroups" output
Fixed bioconda recipe (bioconda/bioconda-recipes#45149) and update orthofinder to 2.5.5 (closes #5312)
FOR CONTRIBUTOR: