Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update orthofinder and pick up new orthogroup output #5705

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

TomHarrop
Copy link
Contributor

@TomHarrop TomHarrop commented Jan 10, 2024

Pick up new "Hierarchical Orthogroups" output

Fixed bioconda recipe (bioconda/bioconda-recipes#45149) and update orthofinder to 2.5.5 (closes #5312)


FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@TomHarrop TomHarrop marked this pull request as draft January 10, 2024 07:46
@TomHarrop TomHarrop changed the title Orthofinder bump Orthofinder bump (waiting for conda recipe) Jan 10, 2024
<requirements>
<requirement type="package" version="@TOOL_VERSION@">orthofinder</requirement>
<requirement type="package" version="2.36">util-linux</requirement>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should show if we can really remove this. Has been added here to allow for containerized tests: #2757

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. That was a mistake. But it passed the tests using this singularity container (and no other dependencies): bioconda/bioconda-recipes#45149 (comment)

Thanks for spotting that, I will test it again once the new container is on quay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernt-matthias this passes tests with the new biocontainer, run in Apptainer, without the util-linux requirement.

Do you think I should leave util-linux out?

@TomHarrop TomHarrop closed this Jan 10, 2024
@TomHarrop TomHarrop reopened this Jan 10, 2024
@TomHarrop TomHarrop changed the title Orthofinder bump (waiting for conda recipe) Orthofinder bump version and pick up new orthogroup output Jan 11, 2024
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomHarrop is this still Draft?

@TomHarrop
Copy link
Contributor Author

Yes. According to the manual the main output been deprecated and I have to pick up the new output in the wrapper.

@TomHarrop TomHarrop changed the title Orthofinder bump version and pick up new orthogroup output Update orthofinder and pick up new orthogroup output Jan 15, 2024
@TomHarrop TomHarrop marked this pull request as ready for review January 15, 2024 03:42
@TomHarrop
Copy link
Contributor Author

Thanks @bgruening, all done now

@bernt-matthias bernt-matthias merged commit 179e3fd into galaxyproject:main Jan 15, 2024
11 checks passed
@TomHarrop TomHarrop deleted the orthofinder_bump branch February 12, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants