DIAMOND: support BLAST DBs and bump to latest version #7519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update test data changes (due to omitting --quiet)
needs consecutive taxIDs
bernt-matthias
force-pushed
the
topic/diamon-updates
branch
from
57b094a to
9f4dfba
Compare
bgruening
approved these changes
Dec 12, 2025
Member
bgruening
left a comment
bgruening
left a comment
There was a problem hiding this comment.
Very cool, looks great to me.
@SaimMomin12 do you want to look over it, since you did the last update?
Member
|
Deployment status: failure https://github.com/galaxyproject/tools-iuc/actions/runs/20164758819 |
5 tasks
Contributor
Author
|
Fix for deployment failure is here #7534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are quite a few CLI arguments that we do not support yet (also without the bump). To me it seemed that most of them are pretty advanced and largely undocumented, so IMO we should implement them only on request.
The test data is completely new. I had to experiment quite a bit to construct test data for the taxonomic data (binary files + sqlite) that is contained in recent BLASTDBs (these are the .btd and .bti files plus the sqlite DB which could also be of interest for the BLAST wrappers .. )
FOR CONTRIBUTOR: