Merge pull request #116 from mvdbeek/fix_get_size

Fix get_dataset_size for datasets with null file_size column
galaxyproject · Nov 22, 2023 · 9218266 · 9218266
2 parents 64830ed + 9ebb84d
commit 9218266
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/tpv/commands/test/mock_galaxy.py b/tpv/commands/test/mock_galaxy.py
@@ -43,6 +43,9 @@ def __init__(self, file_name, file_size):
         self.file_name = file_name
         self.file_size = file_size
 
+    def get_size(self, calculate_size=False):
+        return self.file_size
+
 
 # Tool mock and helpers=========================================
 class Tool:

diff --git a/tpv/core/helpers.py b/tpv/core/helpers.py
@@ -13,7 +13,9 @@
 
 
 def get_dataset_size(dataset):
-    return float(dataset.file_size)
+    # calculate_size would mark file_size column as dirty
+    # and may have unintended consequences
+    return float(dataset.get_size(calculate_size=False))
 
 
 def sum_total(prev, current):