Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved docs #126

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Improved docs #126

merged 7 commits into from
Mar 15, 2024

Conversation

nuwang
Copy link
Member

@nuwang nuwang commented Feb 5, 2024

Closes: #74

Copy link

github-actions bot commented Feb 5, 2024

Pull Request Test Coverage Report for Build 7885947038

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.643%

Totals Coverage Status
Change from base Build 7652799121: 0.0%
Covered Lines: 1015
Relevant Lines: 1043

💛 - Coveralls

Conceptually, TPV consists of the following types of objects.

1. **Entities** - An entity is anything that will be considered for scheduling
by TPV. Entities include Tools, Users, Groups, Rules and Destinations.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this true of Groups?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By Groups, I meant Roles, so I guess it might be better to rename it?

Copy link
Collaborator

@cat-bro cat-bro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nuwang nuwang merged commit a99ec5a into main Mar 15, 2024
1 of 2 checks passed
@nuwang nuwang deleted the improved_docs branch March 15, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a TPV tutorial on the GTN
2 participants