Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contributors to FAQ page #2980

Merged
merged 5 commits into from
Nov 5, 2021
Merged

Conversation

saritadc
Copy link
Contributor

@saritadc saritadc commented Nov 3, 2021

added contributors to the FAQ page.

@shiltemann
Copy link
Member

shiltemann commented Nov 4, 2021

Thanks for your contribution @saritadc! We don't track contributors of FAQs, because they are so small, we only list contributors of tutorials and slides, so this will not display any contributors currently.

If you would like to work on FAQs, we could use somebody who walks through all of them to check if they are still up-to-date with the latest version of Galaxy, since the FAQs cover frequently used tasks in the interface, which changes a lot.

A slightly bigger project here would be to support multiple versions of the FAQs, connected to differenct Galaxy versions, and the ability to switch between them. But we would need to think together about how to do that a bit first.

@hexylena
Copy link
Member

hexylena commented Nov 4, 2021

@shiltemann this is to fix #2973, I was thinking it would be nice to track even if it was small.


{{content | regex_replace: '<hr.*—<\/p>', '' }}
{{content | regex_replace: '<hr.*—<\ /p>', '' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{content | regex_replace: '<hr.*—<\ /p>', '' }}
{{content | regex_replace: '<hr.*—<\/p>', '' }}

I don't think this can have a space here.

Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @saritadc I've tested locally. Would you like to fix the one review comment and also maybe add yourself to the CONTRIBUTORS.yaml file as well? And then I think I'm happy to merge.

@hexylena hexylena linked an issue Nov 5, 2021 that may be closed by this pull request
@saritadc
Copy link
Contributor Author

saritadc commented Nov 5, 2021

@hexylena I have fixed the review comment and I think it's good to go. Thank you!

@hexylena hexylena merged commit 720e82c into galaxyproject:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support contributors on the FAQs
3 participants