-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeatmasking and funannotate: pre-smorg review #4023
Conversation
if you ran it - did you have a workflow invocation? If so we could write a test for this, and test it automatially across the other N usegalaxy.*s |
Good idea! Also just saw the answer in galaxyproject/galaxy#15945 + there are new repeatmasker/modeler releases => will see if I can update these before merging. So switching to draft mode |
awesome! |
Should be good now 🤞 |
@@ -51,4 +51,16 @@ contributors: [hexylena] | |||
``` | |||
|
|||
9. You will need to check the `-tests.yml` file, it has some automatically generated comparisons. Namely it tests that output data matches the test-data exactly, however, you might want to replace that with assertions that check for e.g. correct file size, or specific text content you expect to see. | |||
10. Contribute all of those files to the GTN in a PR. | |||
|
|||
10. If the files in test-data are already uploaded to Zenodo, to save disk space, you should delete them from the `test-data` dir and use their URL in the `-tests.yml` file, as in this example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!! workflow tests are fantastic
Reviewed the repeat masking tutorial before re-recording it. Mainly small cosmetic changes + added a "details" block about repeatmodeler.
Ran it successfully on .fr and .eu