Repeatmasking and funannotate: pre-smorg review #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abretaud
added
genome-annotation
re-record
|
if you ran it - did you have a workflow invocation? If so we could write a test for this, and test it automatially across the other N usegalaxy.*s |
|
Good idea! Also just saw the answer in galaxyproject/galaxy#15945 + there are new repeatmasker/modeler releases => will see if I can update these before merging. So switching to draft mode |
|
awesome! |
shiltemann
previously approved these changes
Apr 19, 2023
|
Should be good now 🤞 |
abretaud
changed the title
hexylena
reviewed
May 3, 2023
| @@ -51,4 +51,16 @@ contributors: [hexylena] | |||
| ``` | |||
|
|
|||
| 9. You will need to check the `-tests.yml` file, it has some automatically generated comparisons. Namely it tests that output data matches the test-data exactly, however, you might want to replace that with assertions that check for e.g. correct file size, or specific text content you expect to see. | |||
| 10. Contribute all of those files to the GTN in a PR. | |||
|
|
|||
| 10. If the files in test-data are already uploaded to Zenodo, to save disk space, you should delete them from the `test-data` dir and use their URL in the `-tests.yml` file, as in this example: | |||
hexylena
reviewed
May 3, 2023
hexylena
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed the repeat masking tutorial before re-recording it. Mainly small cosmetic changes + added a "details" block about repeatmodeler.
Ran it successfully on .fr and .eu