Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Segment #58

Open
1 task
Tracked by #172
palingheorghe opened this issue Nov 12, 2018 · 16 comments
Open
1 task
Tracked by #172

Components: Segment #58

palingheorghe opened this issue Nov 12, 2018 · 16 comments
Labels

Comments

@palingheorghe
Copy link
Collaborator

palingheorghe commented Nov 12, 2018

Read this: Working on a PR | CONTRIBUTING | Galio's docs

As I've written in our wiki. We're working towards v0.5 and for this thing to happen we need the following components.

Do you want to help? Just comment if you wish to work on:

  • Segment (TAKEN BY nobody right now)

Design files for: Segment
We have different folders inside our Segment's design folder, each folder has the purpose of showing the different states this component could have

🤙🏽

@shubhamkakkar
Copy link
Contributor

hey @palingheorghe can you provide me with a gist of your work as I am willing to take this component's work forward

I have implemented a similar component in past, not re-usable though
https://github.com/shubhamkakkar/EXPO-BOILERPLATE-Google-Facebook-LocalAuth/blob/master/src/containers/LoginSignup/LoginSignup.js

@palingheorghe
Copy link
Collaborator Author

Hi @shubhamkakkar I haven't yet started working on this. You could go ahead and create a re-usable Segment component. Thanks for helping out so much!

@kalyantm
Copy link

@shubhamkakkar Hey are u working on this segment component?

@shubhamkakkar
Copy link
Contributor

yes I am working on it
the tabs are ready and its the tab panel that remains

@shubhamkakkar
Copy link
Contributor

Hey, @palingheorghe
https://snack.expo.io/@shubhamkakkar/segment-galio
This is the generic representation of the segment component I have, I just wanted some overview of it, the only thing I believe is left is the theme

@palingheorghe
Copy link
Collaborator Author

Hi @shubhamkakkar can you please push it as a PR so I could test it locally?

@shubhamkakkar
Copy link
Contributor

https://snack.expo.io/@shubhamkakkar/segment-galio
this is the snack for the yet done work!!

@shubhamkakkar
Copy link
Contributor

@palingheorghe I do need a few reviews and feedback related to the structure of this component as compared to the other component

Besides only connection with the theme is left and a few here there too!!!

@palingheorghe
Copy link
Collaborator Author

As @shubhamkakkar couldn't finish this component, I made the issue available again. 🧜🏽‍♂️

@kalyantm
Copy link

@palingheorghe I could pick it up, though I will have to start from scratch.
Will look at the designs and get cracking!

@palingheorghe
Copy link
Collaborator Author

@kalyantm nice! thank you for this, looking forward to your PR.

@kalyantm
Copy link

@palingheorghe hey sorry, my bad thought this was a react component library. Just went through the repo to realise it was react native. Don't have enough expertise to contribute yet, will check again in a few weeks.

@AndyOsei
Copy link
Collaborator

AndyOsei commented Jan 7, 2020

@palingheorghe i’d like to take this on and work on it...

@palingheorghe
Copy link
Collaborator Author

Yes, push your PR whenever you can

@AndyOsei
Copy link
Collaborator

AndyOsei commented Jan 9, 2020

@palingheorghe is each option in the segment supposed to have a panel that slides into view when that option is active or does the component only consists of segmented options without corresponding panels...??

@palingheorghe
Copy link
Collaborator Author

@AndyOsei it should have a panel that slides into view but that panel should be highly configurable (not too many dependencies, maybe the user could actually use a panel created by them and then insert it into the component)

@palingheorghe palingheorghe mentioned this issue Jan 21, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants