-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Segment #58
Comments
hey @palingheorghe can you provide me with a gist of your work as I am willing to take this component's work forward I have implemented a similar component in past, not re-usable though |
Hi @shubhamkakkar I haven't yet started working on this. You could go ahead and create a re-usable Segment component. Thanks for helping out so much! |
@shubhamkakkar Hey are u working on this segment component? |
yes I am working on it |
Hey, @palingheorghe |
Hi @shubhamkakkar can you please push it as a PR so I could test it locally? |
https://snack.expo.io/@shubhamkakkar/segment-galio |
@palingheorghe I do need a few reviews and feedback related to the structure of this component as compared to the other component Besides only connection with the theme is left and a few here there too!!! |
As @shubhamkakkar couldn't finish this component, I made the issue available again. 🧜🏽♂️ |
@palingheorghe I could pick it up, though I will have to start from scratch. |
@kalyantm nice! thank you for this, looking forward to your PR. |
@palingheorghe hey sorry, my bad thought this was a react component library. Just went through the repo to realise it was react native. Don't have enough expertise to contribute yet, will check again in a few weeks. |
@palingheorghe i’d like to take this on and work on it... |
Yes, push your PR whenever you can |
@palingheorghe is each option in the segment supposed to have a panel that slides into view when that option is active or does the component only consists of segmented options without corresponding panels...?? |
@AndyOsei it should have a panel that slides into view but that panel should be highly configurable (not too many dependencies, maybe the user could actually use a panel created by them and then insert it into the component) |
Read this: Working on a PR | CONTRIBUTING | Galio's docs
As I've written in our wiki. We're working towards v0.5 and for this thing to happen we need the following components.
Do you want to help? Just comment if you wish to work on:
Design files for: Segment
We have different folders inside our Segment's design folder, each folder has the purpose of showing the different states this component could have
🤙🏽
The text was updated successfully, but these errors were encountered: