Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Require cycle: on Components <-> Index File #210

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Fix: Require cycle: on Components <-> Index File #210

merged 1 commit into from
Jun 14, 2020

Conversation

zemuldo
Copy link
Contributor

@zemuldo zemuldo commented Jun 13, 2020

Hello Guys. Nice work with this awesome components.

PR has an import restructure for local components to fix the warning below.

Require cycle: node_modules/galio-framework/src/index.js happening on

  • react-native: 0.62.2
  • OS: Mac Catalina 10.15.5
  • Galio Version: 0.6.3

Screenshot

Require Cycle Warning

@palingheorghe
Copy link
Collaborator

Thank you for this PR! We'll make sure to add this in our next patch version update! Really appreciate it! ❤️

@palingheorghe palingheorghe changed the base branch from master to dev June 14, 2020 23:15
@palingheorghe palingheorghe merged commit 86fbf63 into galio-org:dev Jun 14, 2020
@zemuldo
Copy link
Contributor Author

zemuldo commented Jun 15, 2020

Awesome!

@palingheorghe palingheorghe mentioned this pull request Jul 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zemuldo @palingheorghe