-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript Support #226
TypeScript Support #226
Conversation
@palingheorghe @hetmann @yasintz This Pull Request has been pending since August 26. Have you guys given any thought to adding TypeScript support to Galio Framework? If so, could I get some feedback or an assigned reviewer? Thanks in advance. I apologize for all the mentions but it wasn't clear who the best contact would be. |
@RommelTJ while we wait for your PR to be merged, is there a way to include the .d.ts file in our project manually? I tried to copy the .d.ts and refer it to my project in tsconfig.json, but it says "Invalid module name in augmentation. Module 'galio-framework' resolves to an untyped module ". Do you have an idea on how to fix? |
@markronquillo What I originally did was forked this project, add the types to that, and then override your project's However, I didn't want to get out of sync in case this repo got updates, so I backed out of that and instead I just created my own TypeScript wrapper components that extend the Galio components and added a bunch of ignore statements, e.g.
|
Reference Issue
Resolves #205
Description
Adds TypeScript declaration file describing all the galio framework components so that TypeScript projects using the galio-framework can benefit from auto-completion.
Types of changes
Changes
src/index.d.ts
Typescript declaration fileChecklist: