-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme integration #54
Conversation
…ops and propTypes
Neat! Really like the naming conventions you're using. |
Hi, How I found out about the problems:
Using GalioProvider
Right now I cannot find any way of configuring the default theme (or creating a completly different theme) and then pass down my new or modified theme through the Provider. (The Provider doesn't accept any new value as it's using a static variable pre-defined in the theme/index.js file) Using withGalio
const styles = theme => StyleSheet.create({
container: {
flex: 1,
backgroundColor: theme.COLORS.FACEBOOK
}
});
export default withGalio(App, styles); This is working ✅ . My bgColor turned blue using the variable like this in a View component. <View style={this.props.styles.container}> I think we need to better define the purpose of both functions and maybe create some sort of config function in order to configurate the already existent theme or create a new one. Thanks! 🤙🏽 |
✅Both 'withGalio' and 'GalioProvider' functions work correctly now. We'll just have to change the Thanks! ❤️🤙🏽 |
Just updated to version 0.4.0 that fixed the custom theme pass from GalioProvider |
Amazing work @hetmann 👌 |
Just to inform you guys & girls :) I'm writing a small README for the theme to understand how to use it & customise your components. I'll publish the updates in no time :) |
This is it! We're now ready to merge this beautiful new feature into the Alpha-1 branch. Good job everyone! Nice! 🤙🏽 |
withGalio
,GalioProvider
,GalioTheme