Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hitSlop added to left icon #94

Merged
merged 2 commits into from
Sep 11, 2019
Merged

hitSlop added to left icon #94

merged 2 commits into from
Sep 11, 2019

Conversation

zeritte
Copy link
Contributor

@zeritte zeritte commented Jun 13, 2019

this PR is related to: #91
It basically adds hitSlop support to left navbar icon. hitSlop is something recommended by react-native-community, helps developers to improve user experience. (https://facebook.github.io/react-native/docs/improvingux#make-tappable-areas-larger)
example usage:

<NavBar
    style={styles.navbar}
    right={this.renderRight()}
    leftHitSlop={{ top: 30, bottom: 30, left: 30, right: 30 }}
    leftStyle={{ paddingVertical: -12, flex: 0.3 }}
    leftIconColor={theme.COLORS.WHITE}
    titleStyle={styles.title}
    onLeftPress={this.handleLeftPress}
/>

@palingheorghe
Copy link
Collaborator

Hi @zeritte ! Nice job! We'll add this when we merge everything for v0.6 into master! Thanks!

@palingheorghe palingheorghe changed the base branch from master to Alpha-1 September 5, 2019 12:51
@palingheorghe palingheorghe merged commit 13d074b into galio-org:Alpha-1 Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants