add onRef prop to Input component for passing ref to rn text input #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palingheorghe
added
Status: Review Needed
Type: Enhancement
|
Hi @sam1463 ! Thanks for opening up this PR. I'm going to review it when I got more time. This should be really helpful for Galio. Thanks 🤙🏽 |
palingheorghe
added
Accepted for next version
Status: Accepted
and removed
Status: Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would provide a solution for #74 by enabling accessing a ref on the react-native
TextInputcomponent that's the child of the GalioInputcomponent via the proposed newonRefprop, while still enabling using therefprop on the galio component itself.