Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make crowbar pip installable #45

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Make crowbar pip installable #45

merged 1 commit into from
Apr 23, 2020

Conversation

Pamplemousse
Copy link
Contributor

For a better integration with other tools and platforms willing to
integrate it.

For a better integration with other tools and platforms willing to
integrate it.
Copy link

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g0tmi1k g0tmi1k self-assigned this Apr 23, 2020
@g0tmi1k
Copy link
Collaborator

g0tmi1k commented Apr 23, 2020

Wooo!

@g0tmi1k g0tmi1k merged commit 20001e0 into galkan:master Apr 23, 2020
@Pamplemousse Pamplemousse deleted the packaging branch April 23, 2020 20:27
@jonringer
Copy link

unfortunately, this doesn't quite work, pip usually expects a directory, not a top-level python script. So it's unable to "find" crowbar.py.

If I have time, I'll create another PR to have entry_points work as expected

g0tmi1k added a commit that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants