Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ugb/ blocks support for get_the_excerpt API #1413

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Added ugb/ blocks support for get_the_excerpt API #1413

merged 4 commits into from
Aug 2, 2021

Conversation

blankart
Copy link
Contributor

blankart
blankart commented Jul 30, 2021
View reviewed changes
src/blocks.php Outdated Show resolved Hide resolved
@blankart blankart changed the title Added ugb blocks support for get_the_excerpt API Added ugb/ blocks support for get_the_excerpt API Jul 30, 2021
This was linked to issues Jul 30, 2021
contents of advanced text not being displayed in get_the_excerpt() #1123
Closed
Adding stackable block inside a post shows the code of the block in the excerpt in Editor #1271
Closed
@blankart blankart added [version] V2 Affects version 2 only enhancement New feature or request PR: Needs Review This PR needs to be reviewed labels Jul 30, 2021
bfintal
bfintal requested changes Jul 31, 2021
View reviewed changes
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

I don't think we need to include these blocks since they won't really show anything in excerpts and might show unwanted html:

  • ugb/icon
  • ugb/video-popup

@bfintal bfintal added the PR: Reviewed w/ Comments This PR has been reviewed and has comments that need to be resolved label Jul 31, 2021
@blankart blankart removed the PR: Reviewed w/ Comments This PR has been reviewed and has comments that need to be resolved label Aug 2, 2021
@bfintal bfintal merged commit e358025 into master Aug 2, 2021
@bfintal bfintal deleted the get-the-excerpt-support branch August 2, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfintal bfintal bfintal requested changes

Assignees
No one assigned
Labels
enhancement New feature or request PR: Needs Review This PR needs to be reviewed [version] V2 Affects version 2 only
Projects
None yet
Milestone
No milestone
2 participants
@blankart @bfintal