Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (map): allow dynamic content in location field #3105

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

prconcepcion
Copy link
Contributor

fixes #3068

Copy link

github-actions bot commented Mar 12, 2024

🤖 Pull request artifacts

file commit
pr3105-stackable-3105-merge.zip 6fb87ef

github-actions bot added a commit that referenced this pull request Mar 12, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The block produces an error when you have a Google API key in the settings

github-actions bot added a commit that referenced this pull request Mar 14, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If premium and using a Google API Key, using a dynamic field makes the control lose styles and lose description and labels:

No value yet: (correct)
image

With dynamic value: (wrong)
image

github-actions bot added a commit that referenced this pull request Mar 20, 2024
github-actions bot added a commit that referenced this pull request Mar 20, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check, the inspector still doesn't look correct.
image

github-actions bot added a commit that referenced this pull request Mar 20, 2024
github-actions bot added a commit that referenced this pull request Mar 20, 2024
github-actions bot added a commit that referenced this pull request Mar 20, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tweak the styles since the buttons are not aligned.
Screenshot 2024-03-20 at 6 43 06 PM

github-actions bot added a commit that referenced this pull request Mar 20, 2024
github-actions bot added a commit that referenced this pull request Mar 20, 2024
@andeng1106
Copy link

andeng1106 commented Mar 22, 2024

@prconcepcion remaining issues:

  • When changing the values, it's not automatically fetched by the Map block. I need to refresh page, re-add again to see changes.
Screen.Recording.2024-03-22.at.2.46.41.PM.mov
  • If no API key is present and upon fetching dynamic data, it doesn't show correctly on editor
Screen.Recording.2024-03-22.at.7.49.50.PM.mov
  • No API key - Upon refreshing page, the dynamic data deselects and data becomes a text content
Screen.Recording.2024-03-22.at.7.53.06.PM.mov

cc: @bfintal

github-actions bot added a commit that referenced this pull request Apr 16, 2024
github-actions bot added a commit that referenced this pull request Apr 19, 2024
github-actions bot added a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow dynamic values in the location attribute in the Maps block
3 participants