-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Support for Windows Based Docker Images #134
Conversation
…rkflow files to build the new windows containers to match the system in place for ubuntu images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! ❤
Looking good for the most part, a things still need changing to get it into a mergeable state.
.github/workflows/new-windows-post-2019-2-editor-image-requested.yml
Outdated
Show resolved
Hide resolved
|
||
on: | ||
repository_dispatch: | ||
types: [ new_2019_3_plus_editor_image_requested, new_windows_post_2019_2_editor_image_requested ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to find out whether we need pre 2019.3 builds or not.
IL2CPP for windows was introduced with 2019.3, so does that mean there's no point in building any images from before 2019.3? Or is there still some use for XBox or UWP or other platforms.
Perhaps @GabLeRoux you could also pitch in here.
Co-authored-by: Webber Takken <webber.nl@gmail.com>
Co-authored-by: Webber Takken <webber.nl@gmail.com>
Co-authored-by: Webber Takken <webber.nl@gmail.com>
Changes
Checklist