Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Unity Hub from Unity Hub Debian repository #138

Merged
merged 7 commits into from
Jan 14, 2022

Conversation

bkslasher
Copy link
Contributor

Changes

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (not needed)

@github-actions
Copy link

Cat Gif

@webbertakken
Copy link
Member

Great! I think this will come in quite useful.

Two points of concern.

  • Will this automatically update to the next major version as well? We should probably not do that without another PR.
  • Some android tests are failing with an error that I don't think we've seen before.

@bkslasher
Copy link
Contributor Author

bkslasher commented Jan 13, 2022

  • Will this automatically update to the next major version as well? We should probably not do that without another PR.

A required version can be specified. For example: apt-get install unityhub=3.0.0. I can add it as argument to Dockerfile.

@webbertakken
Copy link
Member

Yes that sounds like a good idea. And we can set the default value of the argument to the version number that's currently latest stable.

images/ubuntu/hub/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Webber Takken <webber.nl@gmail.com>
@webbertakken
Copy link
Member

FYI, I cancelled the last 2 workflows, so that the last one can run.

@webbertakken
Copy link
Member

webbertakken commented Jan 13, 2022

I found two new error cases after digging a bit in the logs.

One of the android builds

Unable to list target platforms. Please make sure the android sdk path is correct. 
Error:Invalid command android

And 7 errors in one of the Mac OS builds, that I do not dare quoting because there's a lot that looks wrong but might be fine. Some of which is that it's referring to the "buildslave" from someone at Unity Technologies and other errors.

https://github.com/game-ci/docker/runs/4809269559?check_suite_focus=true

Very cryptic as always, but I'm afraid we'll have to fix all issues (except build cancelled which happens once every 100 jobs) before merging this.

@bkslasher
Copy link
Contributor Author

And 7 errors in one of the Mac OS builds, that I do not dare quoting because there's a lot that looks wrong but might be fine. Some of which is that it's referring to the "buildslave" from someone at Unity Technologies and other errors.

https://github.com/game-ci/docker/runs/4809269559?check_suite_focus=true

Very cryptic as always, but I'm afraid we'll have to fix all issues (except build cancelled which happens once every 100 jobs) before merging this.

This is the relevant part:

The properties of source file /opt/unity/Editor/Data/PlaybackEngines/MacStandaloneSupport/Variations/macos_x64ARM64_player_nondevelopment_mono/UnityPlayer.app/Contents/Frameworks/libmonobdwgc-2.0.dylib could not be retrieved: No such file or directory
[ 77/330    0s] CopyFiles /github/workspace/build/StandaloneOSX/StandaloneOSX.app/Contents/Frameworks/libMonoPosixHelper.dylib
##### ExitCode
-1
##### Output
The properties of source file /opt/unity/Editor/Data/PlaybackEngines/MacStandaloneSupport/Variations/macos_x64ARM64_player_nondevelopment_mono/UnityPlayer.app/Contents/Frameworks/libMonoPosixHelper.dylib could not be retrieved: No such file or directory
[ 78/330    0s] CopyFiles /github/workspace/build/StandaloneOSX/StandaloneOSX.app/Contents/Resources/unity default resources
##### ExitCode
-1
##### Output
The properties of source file /opt/unity/Editor/Data/PlaybackEngines/MacStandaloneSupport/Variations/macos_x64ARM64_player_nondevelopment_mono/UnityPlayer.app/Contents/Resources/unity default resources could not be retrieved: No such file or directory
[118/330    0s] CopyFiles /github/workspace/build/StandaloneOSX/StandaloneOSX.app/Contents/Frameworks/libmono-native.dylib
##### ExitCode
-1
##### Output
The properties of source file /opt/unity/Editor/Data/PlaybackEngines/MacStandaloneSupport/Variations/macos_x64ARM64_player_nondevelopment_mono/UnityPlayer.app/Contents/Frameworks/libmono-native.dylib could not be retrieved: No such file or directory
[231/330    0s] MacOSCodeSignDylibCopy /github/workspace/build/StandaloneOSX/StandaloneOSX.app/Contents/Frameworks/UnityPlayer.dylib```

@bkslasher
Copy link
Contributor Author

The mac-mono faillure is seemingly unrelated. It fails for this other PR too:
https://github.com/game-ci/docker/actions/runs/1632058585

@bkslasher
Copy link
Contributor Author

Android issues are resolved. Looks execute permissions were not properly set for SDK, NDK, Java.

@webbertakken webbertakken merged commit 17ca0d9 into game-ci:main Jan 14, 2022
@webbertakken
Copy link
Member

webbertakken commented Jan 15, 2022

@bkslasher it looks like the android issues are in fact not solved. All builds are failing on android build target.

See current builds based on 0.16.0 https://game.ci/docs/docker/versions

Any ideas?

Edit: Looking at this closer, it seems to be related to disk space. Apparently Android builds are running out of space. I'll check if I can mitigate this, so that the builds succeed and so that we can compare the size of the images between 0.15 and 0.16.0.

\
# Let other users to run sdkmanager as well
&& chmod 755 "${ANDROID_HOME}/tools/bin/sdkmanager" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also restore this line in #139 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants