-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Unity Hub from Unity Hub Debian repository #138
Conversation
Great! I think this will come in quite useful. Two points of concern.
|
A required version can be specified. For example: |
Yes that sounds like a good idea. And we can set the default value of the argument to the version number that's currently latest stable. |
Co-authored-by: Webber Takken <webber.nl@gmail.com>
FYI, I cancelled the last 2 workflows, so that the last one can run. |
I found two new error cases after digging a bit in the logs. One of the android builds
And 7 errors in one of the Mac OS builds, that I do not dare quoting because there's a lot that looks wrong but might be fine. Some of which is that it's referring to the "buildslave" from someone at Unity Technologies and other errors. https://github.com/game-ci/docker/runs/4809269559?check_suite_focus=true Very cryptic as always, but I'm afraid we'll have to fix all issues (except build cancelled which happens once every 100 jobs) before merging this. |
This is the relevant part:
|
The mac-mono faillure is seemingly unrelated. It fails for this other PR too: |
Android issues are resolved. Looks execute permissions were not properly set for SDK, NDK, Java. |
@bkslasher it looks like the android issues are in fact not solved. All builds are failing on android build target. See current builds based on 0.16.0 https://game.ci/docs/docker/versions Any ideas? Edit: Looking at this closer, it seems to be related to disk space. Apparently Android builds are running out of space. I'll check if I can mitigate this, so that the builds succeed and so that we can compare the size of the images between |
\ | ||
# Let other users to run sdkmanager as well | ||
&& chmod 755 "${ANDROID_HOME}/tools/bin/sdkmanager" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also restore this line in #139 ?
Changes
https://docs.unity3d.com/hub/manual/InstallHub.html#install-hub-linux
Checklist