mac-mono: fix x64arm64/x64ARM64 case issue #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davidmfinol
approved these changes
Feb 28, 2022
|
Merging this. It will be available once we roll out the next release. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes not being able to build macos x64 + arm64 builds with ubuntu.
It fixes game-ci/unity-builder#320
This is a bug in Unity, and if/when fixed, this patch should be able to be removed:
https://forum.unity.com/threads/linux-command-line-build-of-macos-has-wrong-mono-path.1200499/
Note, I was able to verify the fix implemented in this PR with a custom docker image:
I am not sure how to test this PR using the artifacts from the CI.
Checklist