-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dedicated server builds #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @paulpach,
This looks good overall.
It would be nice to know how much these additional build target modules add to the images. If it is a lot we might opt to make separate images for these. Hopefully we can go with your solution though.
Could you please verify that the resulting images in fact work as expected when building a project?
Perhaps. Although for Linux and Windows it's quite acceptable it seems. Do server builds require IL2CPP or not? If yes, then that will not be supported in docker, as MacOS images currently do not exist as per macoscontainers.org. In that case we can simply support Windows and Linux with docker and MacOS like we already do in unity-builder (game-ci/unity-builder#326) |
It does not look like it. I was able to build a mono dedicated server. So should I remove the mac support and just leave linux and windows server support? maybe separate them in 3 prs? Honestly I only care about linux servers, I added the other ones for consistency. |
I'm also doubtful about how common the usecase of MacOS server really is. Perhaps the right course of action here is to see the actual difference in disk space of the image builds for Linux and Windows (base target module vs. both base and server target module) - could you please post these based on image builds?. If the difference is within 5% we might just go forward with this, without MacOS server support in a first iteration. What do you think? |
These are the sizes in GB of the docker images obtained by the 'docker images' command
I only care about Linux server. I reckon someone might care about windows server, probably not as often though. I would be surprised if anyone ever asks you for mac server support. |
Despite the % increase I'm thinking lets include Linux Server and Windows Server as targets on their respective platforms and leave MacOS Server out of this entirely. |
Agreed with moving forward with just Linux and Windows servers. I'd also be surprised if anyone ever asked for Mac server. |
If we do move forward with Linux and Windows servers as targets, would they include IL2CPP? |
Server modules are now added for base, linux-il2pp and windows. Works in 2022.*
Looks great! Thank you very much. |
* feat: support dedicated server builds * Remove mac server support * work with base and future unity versions Server modules are now added for base, linux-il2pp and windows. Works in 2022.* * Leave base alone * Remove left over parenthesis * fix log name
Changes
should fix game-ci/documentation#240
Checklist