Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken module matching for server builds #164

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

webbertakken
Copy link
Member

@webbertakken webbertakken commented Mar 21, 2022

Context

Because the server build target platforms for windows and linux were introduced in 2021.2.5 and we didn't account for the first 4 versions of 2021.2, the following versions failed to build:

  • 2021.2.1 linux-il2cpp
  • 2021.2.1 windows
  • 2021.2.2 linux-il2cpp
  • 2021.2.2 windows
  • 2021.2.3 linux-il2cpp
  • 2021.2.3 windows
  • 2021.2.4 linux-il2cpp
  • 2021.2.4 windows

image

Changes

  • Fix regex to only match versions of Editor that support server build platforms.

Proof

# echo "2021.2.1-macos" | grep -vP '^(2021.2.(?![0-4](?![0-9]))|2021.[3-9]|202[2-9]|20[3-9]).*linux'
2021.2.1-macos
# echo "2021.2.1-linux" | grep -vP '^(2021.2.(?![0-4](?![0-9]))|2021.[3-9]|202[2-9]|20[3-9]).*linux'
2021.2.1-linux
# echo "2021.2.5-macos" | grep -vP '^(2021.2.(?![0-4](?![0-9]))|2021.[3-9]|202[2-9]|20[3-9]).*linux'
2021.2.5-macos
# echo "2021.2.5-linux" | grep -vP '^(2021.2.(?![0-4](?![0-9]))|2021.[3-9]|202[2-9]|20[3-9]).*linux'
# echo "2021.2.12-macos" | grep -vP '^(2021.2.(?![0-4](?![0-9]))|2021.[3-9]|202[2-9]|20[3-9]).*linux'
2021.2.12-macos
# echo "2021.2.12-linux" | grep -vP '^(2021.2.(?![0-4](?![0-9]))|2021.[3-9]|202[2-9]|20[3-9]).*linux'
#

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

@github-actions
Copy link

Cat Gif

@webbertakken webbertakken merged commit 1855829 into main Mar 22, 2022
@webbertakken webbertakken deleted the fix-matching-versions branch March 22, 2022 16:00
mob-sakai pushed a commit to mob-sakai/docker that referenced this pull request May 17, 2022
* fix: broken module matching for server builds

* fix: attempt a quick fix excluding other modules

* fix: module matching for server targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants