Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations and errors #198

Merged
merged 6 commits into from
Apr 5, 2023
Merged

Fix deprecations and errors #198

merged 6 commits into from
Apr 5, 2023

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Jan 27, 2023 •
edited
Loading

Changes

  • Replace setoutput with the new environment output method
  • Update node12 to node16
  • Add the test package to unity modules to fix build errors on 2022.2 (Only applied to Unity 2020+ as that is when the package came into support)
  • Lock UnityHub version to a defined value rather than the latest version at the time of build (matches Linux behavior)
  • Add --no-sandbox flag to UnityHub in preparation for the latest v3 release that should allow us to build 2022.2 properly

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

@github-actions
Copy link

Cat Gif

@AndrewKahr AndrewKahr marked this pull request as draft January 27, 2023 06:47
@AndrewKahr AndrewKahr mentioned this pull request Jan 27, 2023
Merged
2 tasks
@AndrewKahr AndrewKahr marked this pull request as ready for review January 27, 2023 09:45
@AndrewKahr
Copy link
Member Author

I can't tell why but I've added --no-sandbox to the editor dockerfile when installing editors via the hub but I don't see the pr CI running with that flag. Does it not test PR code?

@AndrewKahr AndrewKahr marked this pull request as draft January 27, 2023 09:48
@AndrewKahr AndrewKahr marked this pull request as ready for review January 27, 2023 10:47
davidmfinol
davidmfinol approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@davidmfinol davidmfinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKahr AndrewKahr merged commit 67aa53f into game-ci:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmfinol davidmfinol davidmfinol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewKahr @davidmfinol