Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for base module error on Windows #208

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Hotfix for base module error on Windows #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,10 +437,13 @@ jobs:
# The latest patch versions for each minor version.
version: ${{ fromJson(needs.build-matrix.outputs.versions) }}
module:
- base
- windows-il2cpp
- universal-windows-platform
- appletv
include:
- module: base
platform: StandaloneWindows64
- module: windows-il2cpp
platform: StandaloneWindows64
- module: appletv
Expand Down
2 changes: 1 addition & 1 deletion images/windows/editor/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ RUN powershell -Command "&'C:/Program Files/Unity Hub/Unity Hub.exe' '--%' '--no
else { exit 0 }"

ARG module
RUN IF NOT %module% == "base" ( \
RUN IF NOT "%module%"=="base" ( \
powershell -Command \
"&'C:/Program Files/Unity Hub/Unity Hub.exe' '--%' '--no-sandbox --headless \
install-modules --version %version% --module %module% --childModules' 2>$null | \
Expand Down