Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Legacy Windows Image Builds #210

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Disable Legacy Windows Image Builds #210

merged 3 commits into from
Apr 18, 2023

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Apr 17, 2023

Changes

  • New error checking has revealed that legacy Windows images weren't actually working so they will be removed to unblock the build pipeline

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

@github-actions
Copy link

Cat Gif

@webbertakken
Copy link
Member

The code that triggers this repository_dispatch needs to be updated first.

@AndrewKahr
Copy link
Member Author

@webbertakken Not sure I follow. The trigger is a general event of new_legacy_image_requested. I was under the impression the backend will fire this event and when the builds start they report to the backend which saves the editor version and module combinations. Is there somewhere in the backend that knows the version/module pairings too?

@webbertakken
Copy link
Member

webbertakken commented Apr 18, 2023

Right. new_legacy_editor_image_requested is fired from versioning backend.
But now I see what you mean (I didn't understand it from the description at first). You just delete the workflow for the Windows side. LGTM 👍🏻

Have you also considered only removing the trigger, so that people that fork this repo can still use the workflow using the manual build workflow?
Will leave it up to you whether that's better or not.

@AndrewKahr
Copy link
Member Author

Great idea! I've gone ahead and just removed the dispatch trigger.

@AndrewKahr AndrewKahr changed the title Delete new-windows-legacy-editor-image-requested.yml Disable Legacy Windows Image Builds Apr 18, 2023
@AndrewKahr AndrewKahr merged commit 915ffaf into main Apr 18, 2023
@AndrewKahr AndrewKahr deleted the remove-legacy-windows branch April 18, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants