Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Image Build Errors on 2023.2.4f1+ #236

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Fix Image Build Errors on 2023.2.4f1+ #236

merged 6 commits into from
Jan 8, 2024

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Jan 7, 2024

Changes

  • Updates Windows image build script to read the new modules.json format introduced in 2023.2.4f1
  • Removed test builds of older images (activation fails on multiple project builds but those are EOL versions so considering them out of scope)
  • Update test workflow to comply with new activation requirements

Fixes error seen here: https://github.com/game-ci/docker/actions/runs/7361389040

You cannot call a method on a null-valued expression.
At C:\scripts\HelperFunctions.ps1:46 char:8
+ return $rawPath.Replace('{UNITY_PATH}', $UnityPath)
+        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [], ParentContainsErrorRec 
   ordException
    + FullyQualifiedErrorId : InvokeMethodOnNull
 
The command 'powershell.exe -Command if ("$Env:module" -eq 'Android') { .\scripts\SetupAndroid.ps1 }' returned a non-zero code: 1
An image does not exist locally with the tag: unityci/editor
The push refers to repository [docker.io/unityci/editor]
The push refers to repository [docker.io/unityci/editor]
An image does not exist locally with the tag: unityci/editor
An image does not exist locally with the tag: unityci/editor
The push refers to repository [docker.io/unityci/editor]
Error: Process completed with exit code 1.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

Copy link

github-actions bot commented Jan 7, 2024

Cat Gif

@AndrewKahr AndrewKahr merged commit 33cc94c into main Jan 8, 2024
154 of 158 checks passed
@AndrewKahr AndrewKahr deleted the updates-and-fixes branch January 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants