Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full path sdkmanager for all android images #90

Merged
merged 3 commits into from
Mar 15, 2021

Conversation

webbertakken
Copy link
Member

@webbertakken webbertakken commented Mar 2, 2021

Changes

Pending

  • Confirmation that 2018.2 and 2018.1 builds are indeed fixed by this

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

Cat Gif

@mob-sakai
Copy link
Contributor

mob-sakai commented Mar 3, 2021

2018.2 does not support C# 6.0, so the build script needs to be modified.
https://github.com/game-ci/docker/pull/90/checks?check_run_id=2017760557#step:14:1493

-----CompilerOutput:-stderr----------
Assets/Editor/Editor/Input/AndroidSettings.cs(11,58): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification
Assets/Editor/Editor/Input/AndroidSettings.cs(13,58): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification
Assets/Editor/Editor/Input/AndroidSettings.cs(15,58): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification
Assets/Editor/Editor/Input/AndroidSettings.cs(17,58): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification
Assets/Editor/Editor/Input/ArgumentsParser.cs(15,37): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification
Assets/Editor/Editor/Input/ArgumentsParser.cs(17,60): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification
Assets/Editor/Editor/Input/ArgumentsParser.cs(22,60): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification
Assets/Editor/Editor/Input/ArgumentsParser.cs(31,64): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification
Assets/Editor/Editor/Input/ArgumentsParser.cs(37,64): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification
Assets/Editor/Editor/Versioning/Git.cs(109,82): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification
Assets/Editor/Editor/Versioning/Git.cs(109,101): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification

License activation fails in 2018.1.
https://github.com/game-ci/docker/pull/90/checks?check_run_id=2017760571#step:14:141

BTW, the test project was created in 2018.3, so it will not work properly in 2018.2 or earlier.

@webbertakken webbertakken changed the title Use full path sdkmanager, re-enable android fixes for <= 2018.2 Use full path sdkmanager for all android builds Mar 11, 2021
@webbertakken webbertakken changed the title Use full path sdkmanager for all android builds Use full path sdkmanager for all android images Mar 11, 2021
@webbertakken
Copy link
Member Author

I removed the pre 2018.3 part, so this will support usage of java/sdkmanager outside of unity for all versions from 2018.3 and up.

@webbertakken webbertakken merged commit 56ac793 into main Mar 15, 2021
@webbertakken webbertakken deleted the full-path-sdk-manager branch March 15, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some additional environment variables
2 participants