Windows and Mac builds do not raise error when the build fails

[davidmfinol]

Bug description

Windows and Mac builds do not raise error when the build fails

How to reproduce

• Run a build using a windows image or using macos runner
• Have the build fail

Expected behavior

The GitHub actions status should show as errored.

Additional details

The windows builds here failed, but do not show as errored: https://github.com/finol-digital/Card-Game-Simulator/actions/runs/1748742227

[webbertakken]

Déjà vu. We used to have this image in Linux as well. Perhaps we can use a similar same solution.

[wilg]

It doesn't even seem like the process exits when the build fails, at least on my self-hosted runnner.

[wilg]

I see this in my logs, which is perhaps the culprit?

Build failed, with exit code True"

It looks like that's expecting an int? Probably some Windows hogwash.

[wilg]

Seems like something's wrong here, but I don't know anything about PowerShell:

unity-builder/dist/platforms/windows/build.ps1

Lines 128 to 138 in e5e370e

	# Catch exit code
	$Env:BUILD_EXIT_CODE=$?
	# Display results
	if ($Env:BUILD_EXIT_CODE -eq 0)
	{
	Write-Output "Build Succeeded!"
	} else
	{
	Write-Output "$('Build failed, with exit code ')$($Env:BUILD_EXIT_CODE)$('"')"
	}

[wilg]

I think maybe $? needs to be $LastExitCode

[wilg]

Seems like nowhere in the script does it actually exit if there is a failure? I am playing with adding explicit exits on my fork. Not sure if that's the best solution or what, still learning this codebase. https://github.com/wilg/unity-builder

[webbertakken]

Yes, this can probably be improved.

[wilg]

This seems to have been added explicitly, the Mac builder is run with ignoreReturnCode:

https://github.com/game-ci/unity-builder/pull/326/files#diff-235ccbdf6464862b094c2efc53e8144265c6665ad99a973e18bad1c51d113204R8

unity-builder/src/model/mac-builder.ts

Lines 6 to 9 in 3337de4

	await exec('bash', [`${actionFolder}/platforms/mac/entrypoint.sh`], {
	silent,
	ignoreReturnCode: true,
	});

Edit: and because exec returns the error code, it doesn't throw an exception. Example of catching it here: wilg@4c4cb5d

[davidmfinol]

Done by #505