Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Runner v2 #310

Merged
merged 1,093 commits into from
Feb 1, 2022
Merged

Cloud Runner v2 #310

merged 1,093 commits into from
Feb 1, 2022

Conversation

frostebite
Copy link
Member

@frostebite frostebite commented Dec 28, 2021

  • LFS caching
  • Library caching
  • improved simple K8s support
  • improved refactoring of AWS support
  • configurable pre jobs and post jobs
  • experimental hook to inject configurable bash commands at the end or start of any job
  • initial test coverage for cloud runner
  • command-line mode support

@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2021

Codecov Report

Merging #310 (3b5b220) into main (4e38a84) will decrease coverage by 10.75%.
The diff coverage is 27.70%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #310       +/-   ##
===========================================
- Coverage   55.87%   45.12%   -10.76%     
===========================================
  Files          23       51       +28     
  Lines         825     1476      +651     
  Branches      166      239       +73     
===========================================
+ Hits          461      666      +205     
- Misses        362      806      +444     
- Partials        2        4        +2     
Impacted Files Coverage Δ
src/model/cloud-runner/state/cloud-runner-state.ts 8.57% <8.57%> (ø)
src/model/cloud-runner/aws/aws-task-runner.ts 9.37% <9.37%> (ø)
src/model/cloud-runner/aws/aws-job-stack.ts 9.52% <9.52%> (ø)
src/model/cloud-runner/k8s/kubernetes-storage.ts 10.71% <10.71%> (ø)
src/model/cloud-runner/aws/aws-base-stack.ts 11.11% <11.11%> (ø)
src/model/image-environment-factory.ts 11.11% <11.11%> (ø)
src/model/cloud-runner/k8s/index.ts 11.45% <11.45%> (ø)
...cloud-runner/services/task-parameter-serializer.ts 12.50% <12.50%> (ø)
src/model/cloud-runner/aws/aws-templates.ts 14.28% <14.28%> (ø)
...c/model/cloud-runner/k8s/kubernetes-task-runner.ts 14.54% <14.54%> (ø)
... and 28 more

.husky/.gitignore Outdated Show resolved Hide resolved
Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

This is a major leap forward for unity-builder!

LGTM

.github/workflows/cloud-runner-aws-pipeline.yml Outdated Show resolved Hide resolved
.github/workflows/cloud-runner-k8s-pipeline.yml Outdated Show resolved Hide resolved
.husky/.gitignore Outdated Show resolved Hide resolved
.husky/pre-commit Outdated Show resolved Hide resolved
.husky/pre-commit Outdated Show resolved Hide resolved
src/model/input.ts Outdated Show resolved Hide resolved
src/model/input.ts Outdated Show resolved Hide resolved
src/model/input.ts Outdated Show resolved Hide resolved
src/model/input.ts Outdated Show resolved Hide resolved
src/model/input.ts Outdated Show resolved Hide resolved
@frostebite frostebite removed the request for review from davidmfinol December 29, 2021 21:00
@webbertakken webbertakken marked this pull request as draft December 30, 2021 22:35
@webbertakken
Copy link
Member

Converted to draft to mitigate 1 email per commit (see if that works).

@webbertakken
Copy link
Member

Seems like unsubscribing from the PR is the only way. :)

@frostebite frostebite merged commit 03ae77d into main Feb 1, 2022
@frostebite frostebite deleted the remote-builder/unified-providers branch February 1, 2022 02:31
@frostebite frostebite restored the remote-builder/unified-providers branch February 1, 2022 10:21
@Philipp-M Philipp-M mentioned this pull request Apr 5, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants