Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: decouple Linux's build command from GitLab and introduce new features #37

Merged
merged 4 commits into from
Sep 23, 2022
Merged

feat: decouple Linux's build command from GitLab and introduce new features #37

merged 4 commits into from
Sep 23, 2022

Conversation

EricRibeiro
Copy link
Member

@EricRibeiro EricRibeiro commented Sep 23, 2022 •
edited
Loading

Motivation

Closes #34

Changes

  • Stop using GitLab's build script
  • Add support for a custom build-method and custom-parameters
  • Include a new test for both parameters

Notes

Down the road, we might want to move test and prepare-env away from GitLab too. Since they don't require any custom behaviour, I'll leave them for now.

Jaryt
Jaryt approved these changes Sep 23, 2022
View reviewed changes
Copy link

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! And loving the amount of integration tests.

@EricRibeiro EricRibeiro merged commit a9489e1 into game-ci:main Sep 23, 2022
@EricRibeiro EricRibeiro deleted the refactor_linux_decouple branch September 23, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaryt Jaryt Jaryt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom execution method and custom arguments
2 participants
@EricRibeiro @Jaryt