Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unity builder v4 Parity Update #246

Merged
merged 20 commits into from
Dec 13, 2023
Merged

Unity builder v4 Parity Update #246

merged 20 commits into from
Dec 13, 2023

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Dec 11, 2023 •
edited
Loading

Changes

  • Updated activation strategy to align with builder strategy for more stable activation with retry logic
  • Added containerRegistryImageVersion and containerRegistryRepository for improved custom image support
  • Added runAsHostUser to fix self-hosted runner issues
  • Scripts folder cleanup
  • Added error/warning annotations for activation issues
  • Improved serial masking
  • Image environment factory addition and docker refactoring

Related Issues

Related PRs

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions GitHub Actions
Copy link

Cat Gif

GabLeRoux
GabLeRoux approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@GabLeRoux GabLeRoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@AndrewKahr AndrewKahr merged commit ce07478 into main Dec 13, 2023
46 checks passed
@AndrewKahr AndrewKahr deleted the unity-builder-parity branch December 13, 2023 06:12
@oasissoman
Copy link

nice!

@oasissoman oasissoman mentioned this pull request Jan 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogatuadrian bogatuadrian bogatuadrian left review comments

@GabLeRoux GabLeRoux GabLeRoux approved these changes

@davidmfinol davidmfinol davidmfinol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndrewKahr @oasissoman @davidmfinol @GabLeRoux @bogatuadrian