Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the queue #21

Merged
merged 50 commits into from
Oct 19, 2020
Merged

Implement the queue #21

merged 50 commits into from
Oct 19, 2020

Conversation

webbertakken
Copy link
Member

@webbertakken webbertakken commented Oct 17, 2020

Changes

  • This adds the queue that builds the actual images
  • Adds trigger after new editorVersion gets ingested, that creates a CI Job for it, so it can be scheduled
  • Adds trigger after new repoVersion gets ingested (when docker repo ups the version tag), so all editor versions will be built for the updated dockerfiles or other changes.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

@BLaZeKiLL BLaZeKiLL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to build base and hub images for each version ? can't this be re-used ?

@webbertakken
Copy link
Member Author

Do we need to build base and hub images for each version ? can't this be re-used ?

@BLaZeKiLL This will only happen when the docker repository creates a new release. For ingested editorVersions, we'll just build the editor image and that's it.

@webbertakken webbertakken merged commit 4ee0f06 into main Oct 19, 2020
@webbertakken webbertakken deleted the implement-the-queue branch October 19, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants