fix: registerRTT would break successful queries #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A server where I have observed this behaviour: |
CosminPerRam
changed the title
CosminPerRam
force-pushed
the
fix/minecraft_promises
branch
from
e880bb0 to
1629a52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mgrimace encountered issues by using the Homepage project and adding a widget which uses
minecraft, reported here.After some debugging we have cloncluded that the bedrock query runs (from logs, as the target server is bedrock edition) and other fails, but the query still fails.
Commit 9bd3caa is the only a contester as why this happens, OP verified this by making the query with the version before this change (edit: it was not5.0.0-beta.2) which worked.Edit:
Commit 6b85c6b
is also a possiblity(late edit) caused successful queries to fail ifregisterRttwould take too long.This PR pretty much reverses that commit.