Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generate games list with padded delimiter #635

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

RattleSN4K3
Copy link
Contributor

Adresses the issue #607. Script will generate the same output as the current list of games.

Anchors are added back to GAMES_IST.md, to mark the start and end of the list (to be replaced).

Copy link
Member

@CosminPerRam CosminPerRam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks bunch!
Technically this PR does not close #607 (at least completely) as a github workflow is needed to check (and/or overwrite) it.
Would you like to have a try at doing this also? I could merge this and do the CI part separately, but just asking if you're interested (:

@RattleSN4K3
Copy link
Contributor Author

Yeah. I noticed that a CI part is mentioned as well. But I don't think I'm able to fully create the action with every step it requires (like pushing) - less experience with it. Other than copying an existing action and adjusting some parts, I would forward that to you, @CosminPerRam. 😀

@CosminPerRam CosminPerRam merged commit 30ed54d into gamedig:master Sep 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants