feat: Added Satisfactory Protocol and Support #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosminPerRam
requested changes
Sep 24, 2024
|
Hopefully should be OK now. Also thank you for your patience and guidance as I've worked through the options and changes! |
CosminPerRam
requested changes
Sep 28, 2024
CosminPerRam
requested changes
Sep 29, 2024
There was a problem hiding this comment.
The CI fails cause we need to have
extra: {
doc_notes: 'satisfactory',
}
in the game entry for the markdown file to properly link to its section, for example this is the same for Grand Theft Auto V - RageMP:
Line 1289 in 39d7f06
By the way, one can use act to run the github actions locally to avoid waiting for PR reviewer to approve them.
GAMES_LIST.md
Outdated
| @@ -492,5 +493,9 @@ EOS does not provide players data. | |||
| Palworld support can be unstable, the devs mention the api is currently experimental. | |||
| To query Palworld servers, the `RESTAPIEnabled` setting must be `True` in the configuration file, and you need to pass the `username` (currently always `admin`) and the `adminpassword` (from the server config) as the `password` parameter. | |||
|
|
|||
| ### <a name="satisfactory"></a>Satisfactory | |||
| Satisfactory servers unless specified use self-signed certificates for the HTTPS API. Because of this you will need to set the `rejectUnauthorized` flag in options to `false` in order to connect. | |||
There was a problem hiding this comment.
false should be true here.
This was referenced Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Satisfactory, using custom satisfactory protocol.
Related Issues: #442
Please note this is my first PR to this project so please be kind.
Also Satisfactory has only just gone v1.0 therefore the API is limited at the moment. Server Name for example cannot be pulled using the API but a feature request has been submitted to the game developers here which should be voted on for consideration:
https://questions.satisfactorygame.com/post/66ebebad772a987f4a8b9ef8
Example Raw Response
{ "data": { "serverGameState": { "activeSessionName": "MainSession", "numConnectedPlayers": 0, "playerLimit": 4, "techTier": 8, "activeSchematic": "/Script/Engine.BlueprintGeneratedClass'/Game/FactoryGame/Schematics/Progression/Schematic_8-3.Schematic_8-3_C'", "gamePhase": "/Script/FactoryGame.FGGamePhase'/Game/FactoryGame/GamePhases/GP_Project_Assembly_Phase_3.GP_Project_Assembly_Phase_3'", "isGameRunning": true, "totalGameDuration": 183566, "isGamePaused": true, "averageTickRate": 29.907190322875977, "autoLoadSessionName": "MainSession" } } }Note: activeSessionName and autoLoadSessionName are the name of the save file and not the server.