Mark DataPacks as references in callback definitions #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 98f1126 the callback definitions were updated to transitional syntax. However, the ampersand indicating the DataPacks are passed by reference was dropped (I assume accidentally).
In their current state, no plugins are able to use these natives as you'll receive an error when trying to manipulate the Handle:
This happens because the Handle is pushed with
Call_PushCellRef
rather thanCall_PushCell
, therefore requiring the prepended ampersand:plugin-sourcemod/scripting/gameme.sp
Lines 3888 to 3895 in 98f1126