export shapeStyleHelpers #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesopti
reviewed
Jun 22, 2022
packages/tldraw/src/index.ts
Outdated
| @@ -1,6 +1,7 @@ | |||
| export * from './Tldraw' | |||
| export * from './types' | |||
| export * from './state/shapes' | |||
| export * as shapeStyleHelpers from './state/shapes/shared/shape-styles' | |||
There was a problem hiding this comment.
This feels like a strange one off to have as a top level export.
Can we try adding export * from './shared to ./state/shapes/index.ts` instead?
https://github.com/gamma-app/tldraw/blob/main/packages/tldraw/src/state/shapes/index.ts
thatsjonsense
pushed a commit
that referenced
this pull request
Sep 9, 2022
june commits export vec version bump remove curve revert export of core packages export shapeStyleHelpers shapesShared version bump Merge pull request #6 from gamma-app/export-style-helpers export shapeStyleHelpers Disable image box shadow Disable image box shadow Add attrs for shape styles Expose colors on text labels Version bump cleanup Merge pull request #7 from gamma-app/jon/style-classes Add deploy step for core (#9) * Add deploy step for core * Alias tldraw core * Pin core version First deploy core Deploy core script Fix core permissions Consume core from tldraw yarnrc .yarnrc .yarnrc for child packages try workspace Revert "try workspace" This reverts commit 1999219. add top level npmrc Increase line height, bump versions Revert "yarnrc" This reverts commit 48b0625. core first ugh Revert "Revert "yarnrc"" This reverts commit 8dd73bb. restore yarn.lock bump tldraw to use new core bump core dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.