Remove ez_setup.py #1938
Merged
Remove ez_setup.py #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
approved these changes
Nov 21, 2018
|
This is perfectly reasonable, and in fact has been done in astropy_helpers 2.0.7 (but given it shouldn't have any effect or behaviour change, we decided not to issue automated update PRs for that release but to wait until 2.0.8). |
|
CI build fails are the same as before. Looks like this file wasn't used any more (at least in CI). Merging. @bsipocz - Thanks for the advice and review of this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bsipocz @astrofrog - Can the
ez_setup.pyfile be removed? Or is that not advisable?We're still supporting Python 2 in Gammapy, but we don't need to support very old
setuptoolsversions.I'd like to simplify / remove as much as possible.
I can try to update
_astropy_init.pyto resolve this pytest issue pytest-dev/pytest#4390 (comment)but maybe it's easier to do / discuss one change at a time.