Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix router closes client in case of hello timeout #318

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

AdamLutka
Copy link

Solves goroutine leak in case of timeout of HELLO message from client.

Description, Motivation and Context

All other return statements with error in this function are called after method sendAbort that closes client. This PR adds close of client to last case that is missing.

What is the current behavior?

#242

What is the new behavior?

Client is closed after HELLO message timeout. This means that all goroutines of client end and memory can be collected.

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • Overall test coverage is not decreased.
  • All new and existing tests passed.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant