Fix router closes client in case of hello timeout #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves goroutine leak in case of timeout of HELLO message from client.
Description, Motivation and Context
All other return statements with error in this function are called after method
sendAbort
that closes client. This PR adds close of client to last case that is missing.What is the current behavior?
#242
What is the new behavior?
Client is closed after HELLO message timeout. This means that all goroutines of client end and memory can be collected.
What kind of change does this PR introduce?
Checklist: