-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the closest package.json / yarn.lock #1
Comments
yes, it seems like a good idea. I'll try to implement in the next release. |
I think the second behavior is cannot be implemented because of the vscode API simply doesn't support it microsoft/vscode#15991. feel free to submit a pull request if you have a workaround for it. 😃 What I planned is,
|
Yes please! My root directory has multiple projects that are part of a solution so being able to either configure yarn package.json location or currently active open package.json can be used for yarn install would be great. |
* Changed yarn execution behavior, Fix for [Issue 1](#1) 01. If a package.json is opened as an active editor yarn will be invoked on it. 02. If the above scenario fails to satisfy fallback to package.json in project root folder.
I have my |
@kunalgolani Possible. what do you think about the below flow of execution, 1.If a package.json is opened as an active editor/focused tab yarn will be invoked on it. |
@gamunu sounds good to me! |
Addition for [Issue 1]( #1) 1.If a package.json is opened as an active editor/focused tab yarn will be invoked on it. 2.If the package.json is explicitly defined in the configuration yarn will invoke on it. 3.If above scenarios fail to satisfy. The extension will fall back to package.json in project root folder. Fix typescript issues in init file
Closing this. The new feature context menu introduced in v1.5.0 will provide much better integration. |
I have a VSCode project with multiple packages and this extension doesn't seem to recognize it, I get this error:
I guess it's because there is no
package.json
in workspace root.The ideal behavior for me is:
package.json
opened as an active editor,yarn
should be invoked on it (or on the relatedyarn.lock
to be precise).yarn.lock
/package.json
, that should be used as the context.The text was updated successfully, but these errors were encountered: