Added the capability to control the timezone used to display rrd metric graphs

[pcpiela]

Added the capability to control the timezone used to display rrd metric graphs. This is accomplished by specifying a tz query parameter to the ganglia-web url. The timezone parameter takes the standard Linux form, e.g. tz=UTC, tz=America/New_York. The specified timezone is stored as a session variable.

[vvuksan]

Peter,

is there a UI to set it or is the only way to set the timezone to query parameter ? Perhaps adding it as a drop down would be helpful. Does it also affect the JS graphs ?

[pcpiela]

Hi Vladimir,
I was thinking about a UI, but was not sure where to put it. I now think that a dropdown in the vicinity of the time range selection controls would be good. I will put something together for you to look at.

The current implementation does not affect inspect graphs and event input which already assume a browser timezone. I have also not made any modifications to the xport functionality that I believe is used to generate the graph-engine/flot graphs. You could argue that with gweb now having a timezone all functionality involving time including inspect graphs, event input should honor it. We also need to think about the default timezone value (we can continue with server, but provide a conf option to default to browser), and whether the selected timezone should be persisted across sessions.

Peter

From: Vladimir Vuksan [mailto:notifications@github.com]
Sent: Saturday, August 23, 2014 9:40 AM
To: ganglia/ganglia-web
Cc: Peter Piela
Subject: Re: [ganglia-web] Added the capability to control the timezone used to display rrd metric graphs (#245)

Peter,

is there a UI to set it or is the only way to set the timezone to query parameter ? Perhaps adding it as a drop down would be helpful. Does it also affect the JS graphs ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/245#issuecomment-53153115.

[pcpiela]

Vladimir,
what options do you think should be presented in the timezone selector? We could go with Browser, Server only, or add the big list of world timezones.

Peter

From: Vladimir Vuksan [mailto:notifications@github.com]
Sent: Saturday, August 23, 2014 9:40 AM
To: ganglia/ganglia-web
Cc: Peter Piela
Subject: Re: [ganglia-web] Added the capability to control the timezone used to display rrd metric graphs (#245)

Peter,

is there a UI to set it or is the only way to set the timezone to query parameter ? Perhaps adding it as a drop down would be helpful. Does it also affect the JS graphs ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/245#issuecomment-53153115.

[vvuksan]

I'd do browser and server.

On 23. kolovoza 2014. 13:42:54 EDT, pcpiela notifications@github.com wrote:

Vladimir,
what options do you think should be presented in the timezone selector?
We could go with Browser, Server only, or add the big list of world
timezones.

Peter

From: Vladimir Vuksan [mailto:notifications@github.com]
Sent: Saturday, August 23, 2014 9:40 AM
To: ganglia/ganglia-web
Cc: Peter Piela
Subject: Re: [ganglia-web] Added the capability to control the timezone
used to display rrd metric graphs (#245)

Peter,

is there a UI to set it or is the only way to set the timezone to query
parameter ? Perhaps adding it as a drop down would be helpful. Does it
also affect the JS graphs ?

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/245#issuecomment-53153115.

---

Reply to this email directly or view it on GitHub:
#245 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

[pcpiela]

Vladimir,
I added a timezone-picker (Browser/Server) to the time manipulation toolbar, let me know what you think.

Peter