Enable JDBC connection options specification #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling JDBC connection options specification in the ‘connect’ method.
Owner
|
Sorry, not sure how this slipped past. I will merge this, but could you update the README with some example code/options for this new feature? |
Author
|
Sure thing. Will do it over the weekend. |
|
@gantrim Can you please merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to specify JDBC connection options in the ‘connect’ method. The motivation for this change was being able to specify the connection pool size.
This entails addition of the
jdbcOptionsparam to theconnectmethod signature.Users can specify any connection options supported by node-jdbc in the
jdbcOptionsobject. These will be marshalled into theteradataConfigobject in the connect method and passed to node-jdbc when creating the teradata connection instance (teradataInstance).