Update page_head.html.twig #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added favicon output, if enabled in gantry, otherwise it will not render.
| @@ -17,6 +17,9 @@ | |||
| {%- block head_meta -%} | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| {% if gantry.config.styles.base.favicon %} | |||
| <link rel="icon" type="image/x-icon" href="{{ url(gantry.config.get('styles.base.favicon', false)) }}" /> | |||
There was a problem hiding this comment.
Can you remove default value false.. Maybe use the same code as one line above:
<link rel="icon" type="image/x-icon" href="{{ url(gantry.config.styles.base.favicon) }}" />
Updated favicon code to exclude 'default'
| @@ -17,6 +17,9 @@ | |||
| {%- block head_meta -%} | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| {% if gantry.config.styles.base.favicon %} | |||
| <link rel="icon" type="image/x-icon" href="{{ url(gantry.config.styles.base.favicon) }}" /> | |||
There was a problem hiding this comment.
Changed the code to remove 'default' as requested.
|
Looks good to me. |
Closed
|
Sweet! Thank you! |
This was referenced Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added favicon output, if enabled in gantry, otherwise it will not render.