Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore modules with pom packaging #207

Closed
reitzmichnicht opened this issue Apr 4, 2019 · 2 comments · Fixed by #209
Closed

Ignore modules with pom packaging #207

reitzmichnicht opened this issue Apr 4, 2019 · 2 comments · Fixed by #209

Comments

@reitzmichnicht
Copy link

Having maven multi module builds the parent module is normally of packaging type pom, so there are no source folders. But the kslint maven Plugin is passing the default source folders to ktlint which results in 3 warnings.

Kind regards
Michael
freemanjp added a commit that referenced this issue Apr 4, 2019
@freemanjp
Suppressed missing directory warnings on POM modules
c85cd99 
In general, missing source directorates in modules with `pom` packaging does not warrant a warning.

Enhancement: resolves #207
@freemanjp freemanjp mentioned this issue Apr 4, 2019
Merged
freemanjp added a commit that referenced this issue Apr 4, 2019
@freemanjp
Suppressed missing directory warnings on POM modules
89b8154 
In general, missing source directorates in modules with `pom` packaging does not warrant a warning.

Enhancement: resolves #207
freemanjp added a commit that referenced this issue Apr 4, 2019
@freemanjp
Suppressed missing directory warnings on POM modules (#209)
8c64b89 
In general, missing source directorates in modules with `pom` packaging does not warrant a warning.

Enhancement: resolves #207
@freemanjp
Copy link
Member

@reitzmichnicht, thanks for reporting this issue. There are reasons why you may have Kotlin files in a module with pom packaging (e.g. projects that have Maven and Gradle build scripts), so skipping ktlint entirely isn't an option. But for modules with pom packaging I've reduced the logging for missing directories from WARN to DEBUG. You can find this change in #209. This change is in the 0.9.24 release of this plugin.

@reitzmichnicht
Copy link
Author

Thank you for the quick fix, works now as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suppressed missing directory warnings on POM modules gantsign/ktlint-maven-plugin
2 participants
@reitzmichnicht @freemanjp